Removes single quotes from README.md#67
Open
bjorkstromm wants to merge 2 commits intobenaadams:mainfrom
Open
Conversation
Removes single quotes from README.md so that it works with our custom tool that inserts README file content to a SQL DB.
Author
|
This is a must for us!!! The README content of all third party dependencies that we use must be added to our SQL Database. And now we can't do that since it includes single quotes!!!! |
Author
|
Why is this not merged yet? Do I need to submit an issue? |
Owner
|
I think your db has a SQL injection issue |
benaadams
reviewed
Mar 22, 2017
README.md
Outdated
| @@ -1,10 +1,10 @@ | |||
| # System.Ben | |||
| Who says you can't be super fast and super secure | |||
| Who says you can not be super fast and super secure | |||
Owner
There was a problem hiding this comment.
Can be one word cannot; one less space to argue whether it should be a tab.
I will never rebase
Author
|
@benaadams no? SQL Injection? It's not my tool that is wrong, it's your README file that's not compatible, please accept this PR so I can use this library in our software. Always the same, Github repos with non-working README files and people with apostrophes in their names complaining on how we sanitize our SQL statements. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes single quotes from README.md so that it works with our custom tool that inserts README file content to a SQL DB.
ping @benaadams